Skip to content

executor: implement autoAttach from loopback - #25

Closed
bajtos wants to merge 2 commits into
1.xfrom
move-autoattach-from-loopback
Closed

bajtos wants to merge 2 commits into
1.xfrom
move-autoattach-from-loopback

Conversation

@bajtos

@bajtos bajtos commented Jul 21, 2014

Copy link
Copy Markdown
Member

/to @raymondfeng please review
/cc @ritch

@bajtos

bajtos commented Jul 21, 2014

Copy link
Copy Markdown
Member Author

This patch will allow us to remove autoAttach in loopback 2.x.

This should prevent timeout failures on Jenkins CI.
@bajtos

bajtos commented Jul 22, 2014

Copy link
Copy Markdown
Member Author

We can't remove autoAttach from LoopBack while supporting the old project layout (loopback-boot 1.x), becase autoAttach depends on registry.setDefaultDataSourceForType and few other things that cannot be moved to loopback-boot. There isn't much value in moving autoAttach only, I am closing this pull request.

@bajtos bajtos closed this Jul 22, 2014
@bajtos bajtos mentioned this pull request Jul 22, 2014
12 of 47 tasks
@raymondfeng
raymondfeng deleted the move-autoattach-from-loopback branch November 18, 2014 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant